{"id":16711989,"url":"https://github.com/andys8/code-review-talk","last_synced_at":"2026-02-21T11:01:57.436Z","repository":{"id":84195037,"uuid":"492552302","full_name":"andys8/code-review-talk","owner":"andys8","description":"Run: mdp -c README.md","archived":false,"fork":false,"pushed_at":"2022-05-19T07:28:14.000Z","size":7,"stargazers_count":0,"open_issues_count":0,"forks_count":0,"subscribers_count":1,"default_branch":"master","last_synced_at":"2025-10-18T17:34:58.029Z","etag":null,"topics":["codereview","mdp","talk"],"latest_commit_sha":null,"homepage":"https://github.com/visit1985/mdp","language":null,"has_issues":true,"has_wiki":null,"has_pages":null,"mirror_url":null,"source_name":null,"license":null,"status":null,"scm":"git","pull_requests_enabled":true,"icon_url":"https://github.com/andys8.png","metadata":{"files":{"readme":"README.md","changelog":null,"contributing":null,"funding":null,"license":null,"code_of_conduct":null,"threat_model":null,"audit":null,"citation":null,"codeowners":null,"security":null,"support":null,"governance":null,"roadmap":null,"authors":null,"dei":null,"publiccode":null,"codemeta":null,"zenodo":null}},"created_at":"2022-05-15T17:11:30.000Z","updated_at":"2022-05-19T08:56:53.000Z","dependencies_parsed_at":"2023-05-23T22:00:11.923Z","dependency_job_id":null,"html_url":"https://github.com/andys8/code-review-talk","commit_stats":null,"previous_names":[],"tags_count":0,"template":false,"template_full_name":null,"purl":"pkg:github/andys8/code-review-talk","repository_url":"https://repos.ecosyste.ms/api/v1/hosts/GitHub/repositories/andys8%2Fcode-review-talk","tags_url":"https://repos.ecosyste.ms/api/v1/hosts/GitHub/repositories/andys8%2Fcode-review-talk/tags","releases_url":"https://repos.ecosyste.ms/api/v1/hosts/GitHub/repositories/andys8%2Fcode-review-talk/releases","manifests_url":"https://repos.ecosyste.ms/api/v1/hosts/GitHub/repositories/andys8%2Fcode-review-talk/manifests","owner_url":"https://repos.ecosyste.ms/api/v1/hosts/GitHub/owners/andys8","download_url":"https://codeload.github.com/andys8/code-review-talk/tar.gz/refs/heads/master","sbom_url":"https://repos.ecosyste.ms/api/v1/hosts/GitHub/repositories/andys8%2Fcode-review-talk/sbom","scorecard":null,"host":{"name":"GitHub","url":"https://github.com","kind":"github","repositories_count":286080680,"owners_count":29679049,"icon_url":"https://github.com/github.png","version":null,"created_at":"2022-05-30T11:31:42.601Z","updated_at":"2026-02-21T09:33:50.764Z","status":"ssl_error","status_checked_at":"2026-02-21T09:33:19.949Z","response_time":107,"last_error":"SSL_connect returned=1 errno=0 peeraddr=140.82.121.5:443 state=error: unexpected eof while reading","robots_txt_status":"success","robots_txt_updated_at":"2025-07-24T06:49:26.215Z","robots_txt_url":"https://github.com/robots.txt","online":false,"can_crawl_api":true,"host_url":"https://repos.ecosyste.ms/api/v1/hosts/GitHub","repositories_url":"https://repos.ecosyste.ms/api/v1/hosts/GitHub/repositories","repository_names_url":"https://repos.ecosyste.ms/api/v1/hosts/GitHub/repository_names","owners_url":"https://repos.ecosyste.ms/api/v1/hosts/GitHub/owners"}},"keywords":["codereview","mdp","talk"],"created_at":"2024-10-12T20:27:54.258Z","updated_at":"2026-02-21T11:01:57.422Z","avatar_url":"https://github.com/andys8.png","language":null,"funding_links":[],"categories":[],"sub_categories":[],"readme":"%title: Code Review\n%author: e-bot7\n%date: 2022-05-19\n\n```\n     _____          _          _____            _\n    / ____|        | |        |  __ \\          (_)\n   | |     ___   __| | ___    | |__) |_____   ___  _____      __\n   | |    / _ \\ / _` |/ _ \\   |  _  // _ \\ \\ / / |/ _ \\ \\ /\\ / /\n   | |___| (_) | (_| |  __/   | | \\ \\  __/\\ V /| |  __/\\ V  V /\n    \\_____\\___/ \\__,_|\\___|   |_|  \\_\\___| \\_/ |_|\\___| \\_/\\_/\n\n```\n\n---\n\n-\u003e # Code Review\n\n## Agenda\n\n- Pull request with code review and CI\n- Author's perspective\n- Reviewer's perspective\n- Discussion\n\n---\n\n# What's a Pull Request?\n\n\u003e Pull requests let you _tell others about changes_\n\u003e you've pushed to a branch in a repository on GitHub.\n\u003e Once a pull request is opened, you can **discuss** and\n\u003e **review** the potential changes with collaborators\n\u003e and **add follow-up commits** before your changes\n\u003e are merged into the base branch.\n\n[Github](https://docs.github.com/pull-requests/collaborating-with-pull-requests)\n\n---\n\n# Why Code Reviews?\n\n## Goal\n\n- Goal: Improve the quality of the code that's added\n- Systematic approach to reviewing new code for mistakes\n- Checks if all _requirements_ have been implemented correctly\n\n---\n\n# Why Code Reviews?\n\n## Share Knowledge\n\n\u003e Code review is **more than just a quality check**\n\nMultiple developers looking at the PR:\n\n- They are exposed to new code\n- Reviewers _have to understand_ the context and scope\n- Can be a great tool to reduce technical debt\n\n---\n\n# Why Code Reviews?\n\n## Get Feedback\n\nCan be a valuable learning moment for developers\n=\u003e Get _feedback_ about your code and coding style\n\n---\n\n# Pull Request and Code Review\n\n- In general: Pull request setup and CI\n- Author: How to **create** a pull request?\n- Reviewer: How to **review** a pull request?\n\n---\n\n# Pull Request: Setup\n\nOpinionated, whatever works _best for the team_\n\n- Decide how developers are assigned\n- Decide how comments should be handled\n- Define number of approvals and the condition\n\n---\n\n# Pull Request: CI (Continuous Integration)\n\n\u003e Automate everything that's possible\n\n- Tests\n- Code Coverage\n- Deployment\n- Formatting\n- Static code analysis\n- Special rules e.g. line length or forbidden imports\n\n---\n\n# Author: How to Create a Pull Request?\n\nHow to open a pull request that can easily be reviewed?\n\n---\n\n# Create a Pull Request\n\n## Share Insights\n\n\u003e What would you tell somebody?\n\n- \"No description provided\"?!\n- \"WIP\" or \"Make linter happy\"?!\n\n---\n\n# Create a Pull Request\n\n## Share Insights\n\n\u003e What would you tell somebody?\n\nDon't explain what is clear already,\nbut explain what is **interesting to others**.\n\n- What were the decisions and why?\n- Are you uncertain about some decisions?\n\n---\n\n# Create a Pull Request\n\n## Description\n\nScreenshots or video\nSmaller changes are easier to review\nCommits (and commit messages) can be powerful\nSpeak about controversial questions before code review\n\n---\n\n# Create a Pull Request\n\n## Share Knowledge\n\nAlso leverage other formats:\n\n- Session to discuss a topic in detail\n- Small presentation\n\n---\n\n# Create a Pull Request\n\n## Self-Review\n\nReview your own pull request\n... and this time it's **fine if you're nitpicky**\n\nAvoid unfinished pull requests and multiple review loops\n\n---\n\n# Reviewer: How to Review a Pull Request?\n\nHow to give valuable feedback?\n\n---\n\n# Code Review\n\n## Friendly Atmosphere\n\nServes the team, is _not about letting pass_\n**Language** is important and might be perceived negatively\nFeel free to praise what you like\nCode reviews aren't a tool to criticize colleagues\n\nComments should be **about code**\n\n---\n\n# Code Review\n\n## Goal: Specific and Actionable Feedback\n\nClear and **over-communicate**\nTell what to do or \"you decide\"\nBetter ask questions rather than making statements\nWith enough information to be able to understand the question\n\n---\n\n# Code Review\n\n## Try the Code\n\nCheckout and **run** the code\nTry to **understand**\nTry to **break it** (QA)!\n\n---\n\n# Code Review\n\n## Add Comments\n\n- If you don't understand: **Do not trust, ask questions**\n- Discussions, but keep them small ⚠️\n- Code suggestions or PR-in-PR? ⚠️\n- Differentiate if code suggestion would be _opinionated_ ⚠️\n- Check your review again\n\n---\n\n# Code Review\n\n## Questions About the Change\n\n- How important is the code that is changed?\n- Do I understand the change?\n- Are feature requirements covered?\n- Could the change break something or other teams?\n- What are the edge cases?\n- Could this introduce security issue?\n- Were tests added?\n\n---\n\n# Code Review\n\n## Questions About the Code\n\n- Is there a simpler way to achieve the same goal?\n- Is documentation missing / needs to be updated?\n- Is the change consistent (naming, modules, libraries)?\n- Is the code self-explanatory?\n- Could reorganizing improve readability?\n\n---\n\n# Code Review Discussion\n\nWhat is working well for you?\n\n**End**\n\n---\n\n# Sources\n\n- [Clément Mihailescu](https://www.youtube.com/watch?v=1Ge__2Yx_XQ)\n- [Alex Omeyer](https://dev.to/alexomeyer/code-review-a-comprehensive-checklist-5gnm)\n","project_url":"https://awesome.ecosyste.ms/api/v1/projects/github.com%2Fandys8%2Fcode-review-talk","html_url":"https://awesome.ecosyste.ms/projects/github.com%2Fandys8%2Fcode-review-talk","lists_url":"https://awesome.ecosyste.ms/api/v1/projects/github.com%2Fandys8%2Fcode-review-talk/lists"}