Ecosyste.ms: Awesome

An open API service indexing awesome lists of open source software.

Awesome Lists | Featured Topics | Projects

https://github.com/alvarogarcia7/kata-codereview-01-commandbuilder-javascript

jasmine javascript js kata tdd underscore

Last synced: about 1 month ago
JSON representation

Host: GitHub
URL: https://github.com/alvarogarcia7/kata-codereview-01-commandbuilder-javascript
Owner: alvarogarcia7
License: mit
Created: 2014-09-06T08:42:27.000Z (over 10 years ago)
Default Branch: master
Last Pushed: 2014-09-15T21:06:58.000Z (over 10 years ago)
Last Synced: 2024-05-21T05:18:42.116Z (7 months ago)
Topics: jasmine, javascript, js, kata, tdd, underscore
Language: JavaScript
Size: 188 KB
Stars: 0
Watchers: 3
Forks: 1
Open Issues: 1
Metadata Files:
- Readme: README.md
- License: LICENSE

Awesome Lists containing this project

README

        kata-codereview-01-commandBuilder

================

Code review kata, for a command builder scenario

It has been developed using "a TDD cycle without refactoring"

Spanish (English below)

================

* la kata está resuelta, todos los tests pasan

* el comportamiento es correcto

* el código ha sido desarrollado bajo mucha presión por un junior del consejo de sabios. Esta persona no sabe mucho de refactorizar, patrones, DRY, SOLID, etc

* Vuestro trabajo es hacer un code review sobre su código para ayudarle a mejorar:

    * cosas que se pueden mejorar (SOLID)

    * cosas que se pueden eliminar (DRY)

    * cosas que se pueden renombrar (tema naming)

    * ...

    * no es necesario proponer una solución mejorada o alternativa. Lo único que se pide es el code review. Por supuesto, cualquier solución será bienvenida y el consejo de sabios la corregirá

Este code review no nos ha llevado más de 15 minutos (son literalmente 20 líneas de código), así que en ningún caso os debería llevar más de 45 minutos

Repito: no es necesario proponer una solución mejorada o alternativa. Lo único que se pide es el code review. Por supuesto, cualquier solución será bienvenida y el consejo de sabios la corregirá

El deadline es el jueves 11/9 EOD (end of day). Por favor, para los que toméis el reto, enviad la solución por pull request

Aclaraciones:

* se puede modificar la API pública buildCommand(commandNameAndArguments) si lo consideráis necesario

* Se valorará especialmente el tema del naming

* deadline jueves 11/9 EOD (end of day)

English

================

* The kata has been solved, all tests are currently passing

* The behavior is correct, the expected one

* The code has been by a junior developer, under a lot of pressure. This person doesn't know much about refactoring, patterns, DRY, SOLID, etc

* It's your job, should you accept the mission, to help him with a code review:

    * things to improve (SOLID)

    * things to remove (DRY)

    * things to rename (naming)

    * ...

    * It's not necessary to propose an alternative or better solution. What it's requires is to code review the code. Even though, any solution will be welcome and code reviewed by us.

This code review is short (literally 20 lines of code), so it should not take you back more than 45 minutes. (Took us 15 minutes)

Again: It's not necessary to propose an alternative or better solution. What it's requires is to code review the code. Even though, any solution will be welcome and code reviewed by us.

If you know our work email, the deadline is September 11/9 EOD (end of day). If you don't know the work email, the deadline is open. For those of you who accept the mission, please send the code review in a text file by pull request

Hints:

* you can modify the public API buildCommand(commandNameAndArguments) if you consider it appropiate

* The naming code review will be especially welcome

* the deadline is September 12th EOD (end of day)

Disclaimer: If there are "too many" (at the owner's decision) pull requests, the repository owner reserves the right to not correct them all