https://github.com/bbqbaron/zhenghe

https://github.com/bbqbaron/zhenghe

Last synced: 17 days ago
JSON representation

• Host: GitHub
• URL: https://github.com/bbqbaron/zhenghe
• Owner: bbqbaron
• Created: 2016-11-24T03:35:46.000Z (about 8 years ago)
• Default Branch: master
• Last Pushed: 2016-11-29T11:33:06.000Z (about 8 years ago)
• Last Synced: 2024-12-10T03:06:22.495Z (26 days ago)
• Language: Swift
• Size: 37.1 KB
• Stars: 0
• Watchers: 1
• Forks: 1
• Open Issues: 1
• Metadata Files:
  • Readme: README.md

Awesome Lists containing this project

README

        
# Zheng He

is a toy location search app named for the Chinese explorer [Zheng He](https://en.wikipedia.org/wiki/Zheng_He).

# Dependencies Reviewed

* [Carthage](https://github.com/Carthage/Carthage) for package management. It's a popular standard choice right now; I don't have an opinionated preference over, say, CocoaPods.

* [SwiftyJSON](https://github.com/SwiftyJSON/SwiftyJSON) to slightly ease the pain of JSON parsing. We had to roll our own a year ago, and easy reflection-based JSON is one of the few things I miss from Javaland. It's naturally overkill in this case, but let's pretend this app is supposed to get larger.

* [RxSwift](https://github.com/ReactiveX/RxSwift) and associated libs for reactivity. I haven't developed a strong preference between Rx* and Reactive*; we sadly couldn't use either in our last app, but this has been a great opportunity to exercise one of them a little.

* [SwiftLint](https://github.com/realm/SwiftLint) is run if installed; always handy to have something to yell at you.

# Misc Remarks

Being time-constrained, I'd like to acknowledge a few points of good app structure that aren't present here:

* Protocols aren't used to ease dependency stubbing

* UI tests are a very useful and totally absent tool!

* URL construction by string interpolation isn't a great generalizeable pattern.

* External URLs of things like Geonames shouldn't be hardcoded in source code.