https://github.com/devversion/bazel-ngc-wrapped-invalid-imports

https://github.com/devversion/bazel-ngc-wrapped-invalid-imports

Last synced: about 1 month ago
JSON representation

• Host: GitHub
• URL: https://github.com/devversion/bazel-ngc-wrapped-invalid-imports
• Owner: devversion
• Created: 2019-09-16T08:02:08.000Z (over 5 years ago)
• Default Branch: master
• Last Pushed: 2022-12-04T12:07:11.000Z (about 2 years ago)
• Last Synced: 2024-11-11T06:12:22.484Z (2 months ago)
• Language: Python
• Size: 336 KB
• Stars: 0
• Watchers: 3
• Forks: 0
• Open Issues: 14
• Metadata Files:
  • Readme: README.md

Awesome Lists containing this project

README

        
# bazel-ngc-wrapped-invalid-imports

Read more about the issue here: https://hackmd.io/MlqFp-yrSx-0mw4rD7dnQQ

### How to reproduce:

* `bazel build packages/material/snack-bar`

* Open `./bazel-bin/packages/material/snack-bar.js`

* See how NGC generated an import to `@angular/cdk/overlay/overlay`. This is

incorrect as the import should always refer to public name of the entry-point.

### How to reproduce the Bazel "generateCodeForLibaries" issue:

1. `yarn ngc -p test-vanilla-ngc/a/tsconfig.json`

2. `yarn ngc -p test-vanilla-ngc/b/tsconfig.json`.

Both of these compilations work. `b` properly builds

with metadata of `a`.

Now change in `test-vanilla-ngc/b/tsconfig.json` the

`generateCodeForLibraries` option and notice how

the metadata of `a` is discarded if you rebuild

`b`.

3. `yarn ngc -p test-vanilla-ngc/b/tsconfig.json`.