https://github.com/eclipseisoffline/jukeboxcustomdiscfix
This mod fixes bug MC-260346, which causes custom music discs, when played in a jukebox, to be cut off when the vanilla disc would normally end.
https://github.com/eclipseisoffline/jukeboxcustomdiscfix
minecraft minecraft-mod minecraft-resourcepack
Last synced: about 2 months ago
JSON representation
This mod fixes bug MC-260346, which causes custom music discs, when played in a jukebox, to be cut off when the vanilla disc would normally end.
- Host: GitHub
- URL: https://github.com/eclipseisoffline/jukeboxcustomdiscfix
- Owner: eclipseisoffline
- License: lgpl-3.0
- Created: 2024-02-28T12:21:07.000Z (about 1 year ago)
- Default Branch: main
- Last Pushed: 2024-08-28T14:49:11.000Z (9 months ago)
- Last Synced: 2024-08-28T16:24:08.391Z (9 months ago)
- Topics: minecraft, minecraft-mod, minecraft-resourcepack
- Language: Java
- Homepage: https://modrinth.com/mod/jukebox-custom-disc-fix
- Size: 121 KB
- Stars: 0
- Watchers: 1
- Forks: 0
- Open Issues: 1
-
Metadata Files:
- Readme: README.md
- Funding: .github/FUNDING.yml
- License: LICENSE
Awesome Lists containing this project
README
# Jukebox Custom Disc Fix
[](https://modrinth.com/mod/jukebox-custom-disc-fix)
[](https://modrinth.com/mod/jukebox-custom-disc-fix)
[](https://modrinth.com/mod/jukebox-custom-disc-fix)
[](https://discord.gg/CNNkyWRkqm)
[](https://github.com/eclipseisoffline/jukeboxcustomdiscfix)
## Minecraft 1.21 notice
The bug report for the bug this mod fixes has been marked as resolved as of Minecraft 1.21.
This mod will continue to be updated and has a 1.21 version, however as of Minecraft 1.21 it is
strongly recommended to use the vanilla Minecraft way of adding custom discs, which is through datapacks.
Information about how to do so can be found [here](https://minecraft.wiki/w/Jukebox_song_definition).
If you still wish to listen to custom discs through just the use of a resource pack though, you will need this mod.
As of 1.21 this mod now fixes the bug client-side as well, meaning you can join every server with a custom disc resource pack, without the disc being cut off.
## README
This mod fixes bug [MC-260346](https://bugs.mojang.com/browse/MC-260346), which causes custom music
discs, when played in a jukebox, to be cut off when the vanilla disc would normally end.
The fix is implemented server-side by only telling the client to stop playing a disc sound when the disc item is removed
from the jukebox (either by a hopper or by a player clicking on the jukebox), whereas in vanilla
Minecraft the client is told to stop playing a disc sound as soon as the vanilla disc would end.
As of Minecraft 1.21 (mod version 0.1.4-1.21), this mod has a client-side fix as well. This is implemented
by ignoring all packets the server sends to the client that tell the client to stop playing a song,
and instead have the client only stop playing a song when the `has_record` block state for the jukebox
playing the song has been set to `false`.
When installed on servers, this mod does not have to be installed on clients connecting.
Feel free to report any bugs, at the issue tracker.
## License
This mod is licensed under GNU LGPLv3.
## Donating
If you like this mod, consider [donating](https://buymeacoffee.com/eclipseisoffline).
## Discord
For support and/or any questions you may have, feel free to join [my discord](https://discord.gg/CNNkyWRkqm).
## Version support
| Minecraft Version | Fabric | Quilt | NeoForge | Forge |
|-------------------|-------------------------------|-------------------------------|-------------------------------------|-------------------------------------|
| 1.21.5 | ✅ Current | ✔️ Use Fabric version | ❌ Unavailable | ❌ Unavailable |
| 1.21.4 | ✅ Current | ✔️ Use Fabric version | ❌ Unavailable | ❌ Unavailable |
| 1.21.2+3 | ✅ Current | ✔️ Use Fabric version | ❌ Unavailable | ❌ Unavailable |
| 1.21+1 | ✅ Current | ✔️ Use Fabric version | ❌ Unavailable | ❌ Unavailable |
| 1.20.5+6 | ✅ Current, no client side fix | ✅ Current, no client side fix | ✔️ Available, won't receive support | ❌ Unavailable |
| 1.20.4 | ✅ Current, no client side fix | ✅ Current, no client side fix | ✔️ Available, won't receive support | ❌ Unavailable |
| 1.20.2 | ✅ Current, no client side fix | ✔️ Use Fabric version | ❌ Unavailable | ❌ Unavailable |
| 1.20.1 | ✅ Current, no client side fix | ✔️ Use Fabric version | ✔️ Available, won't receive support | ✔️ Available, won't receive support |
I try to keep support up for the latest major and latest minor release of Minecraft. Updates to newer Minecraft
versions may be delayed from time to time, as I do not always have the time to immediately update my mods.
Unsupported mods are still available to download, but they won't receive new features or bugfixes.
Ports for modloaders other than Fabric are available for 1.20.x versions, but supporting other modloaders is quite a hassle and I decided
it wouldn't be worth the effort anymore for 1.21.x versions and above.
## Usage
Mod builds can be found on the releases page, as well as on [Modrinth](https://modrinth.com/mod/jukebox-custom-disc-fix).
The Fabric API is not required. This mod is not required on clients when playing multiplayer and the mod is installed server-side.