https://github.com/hugodf/nextjs-error-serverside-props
https://github.com/hugodf/nextjs-error-serverside-props
Last synced: 22 days ago
JSON representation
- Host: GitHub
- URL: https://github.com/hugodf/nextjs-error-serverside-props
- Owner: HugoDF
- Created: 2022-10-24T08:35:32.000Z (over 2 years ago)
- Default Branch: master
- Last Pushed: 2022-10-24T08:44:17.000Z (over 2 years ago)
- Last Synced: 2025-02-14T01:39:11.082Z (3 months ago)
- Language: TypeScript
- Size: 59.6 KB
- Stars: 0
- Watchers: 2
- Forks: 0
- Open Issues: 0
-
Metadata Files:
- Readme: README.md
Awesome Lists containing this project
README
# Next.js pageProps empty client-side for `_error` page reproduction
Issue:
- `pageProps = {}` client-side for `_error`
Bisect:
- Last working version: 12.2.0, see [error-serverside-props-next-12.2.0](./error-serverside-props-next-12.2.0)
- `cd error-serverside-props-next-12.2.0 && yarn build && yarn start`
- open the Next.js URL
- Expected behaviour `Next stars: 94257` (number might change)
- First broken version: 12.2.1, see [error-serverside-props-next-12.2.1](./error-serverside-props-next-12.2.1)
- `cd error-serverside-props-next-12.2.1 && yarn build && yarn start`
- open the Next.js URL
- Expected behaviour `Next stars: 94257` (number might change)
- Actual behaviour:
- `Next stars: 94257` populated properly on SSR pass
- when the page JavaScript kicks in, it gets replaced with `Next stars:` (no more star count)
- issue is also present in canary version (12.3.1-canary), see [error-serverside-props-next-canary](./error-serverside-props-next-canary)
- Comparison between working and broken releases: https://github.com/vercel/next.js/compare/v12.2.0...v12.2.1
- likely breaking PR/commit:
- https://github.com/vercel/next.js/pull/21240/files
- https://github.com/vercel/next.js/commit/69f8024aa1cdef3125113c0e6e3cb4ec7c44fe8a
- key change https://github.com/vercel/next.js/commit/69f8024aa1cdef3125113c0e6e3cb4ec7c44fe8a#diff-2433946f9a058f1b070138d12c20f10a9128e46408033629181f9f7fc3b9b9b2
- change description: replacing the props (including pageProps) with the output of `Error.getInitialProps` unless the error was a "throw during render"
- effect: we don't have getInitialProps on App or Error component, props are being set to `{}` (see here https://github.com/vercel/next.js/blob/92254d137ad87f7b48d3305ebf50751e8c68f8e6/packages/next/shared/lib/utils.ts#L367-L375)