https://github.com/kingnoosh/cli-warehouse
https://github.com/kingnoosh/cli-warehouse
Last synced: 12 months ago
JSON representation
- Host: GitHub
- URL: https://github.com/kingnoosh/cli-warehouse
- Owner: KingNoosh
- Created: 2016-12-11T21:16:34.000Z (about 9 years ago)
- Default Branch: master
- Last Pushed: 2016-12-11T23:27:43.000Z (about 9 years ago)
- Last Synced: 2025-01-07T10:29:16.147Z (about 1 year ago)
- Language: Ruby
- Size: 5.86 KB
- Stars: 0
- Watchers: 1
- Forks: 0
- Open Issues: 0
-
Metadata Files:
- Readme: README.md
Awesome Lists containing this project
README
# cli-warehouse
I'd like to point out that I've only spent a total of around 4 hours on this and that Ruby hasn't been my primary language for a year.
Things may not be as clean as they should be but I'll be going through each of my "smells" and doubts later on.
## Why did I do it the way I did?
While in the rush of writing all of this code, I've been relying on my instincts on asking myself the right questions and knowing whether I should spend more time refactoring or move on.
## How can I improve this?
- Allocate much more time to this test.
- Clean up repeated error messages.
- Reduce the amount of casting I'm doing to variables.
- Returning with a string instead of putting would've made this easier to unit test.
- Spec style unit tests might've actually reduced the amount of lines of code I've written.