https://github.com/kyleam/covr-r44-issues
https://github.com/kyleam/covr-r44-issues
Last synced: 9 months ago
JSON representation
- Host: GitHub
- URL: https://github.com/kyleam/covr-r44-issues
- Owner: kyleam
- Created: 2024-11-14T14:07:01.000Z (over 1 year ago)
- Default Branch: main
- Last Pushed: 2024-11-15T17:10:55.000Z (over 1 year ago)
- Last Synced: 2025-01-25T15:11:58.367Z (over 1 year ago)
- Language: Makefile
- Size: 27.3 KB
- Stars: 0
- Watchers: 1
- Forks: 0
- Open Issues: 0
-
Metadata Files:
- Readme: README.md
Awesome Lists containing this project
README
* [Overview](#overview)
* [Slowdown](#slowdown)
* [data.table](#datatable)
* [diffobj](#diffobj)
* [R.utils](#rutils)
* [Exclusions error](#exclusions-error)
* [data.table](#datatable-1)
* [diffobj](#diffobj-1)
* [nanotime](#nanotime)
Overview
--------
This repository demonstrates two issues with covr and R 4.4:
* calculating coverage for R.utils shows a substantial slowdown
* calculating coverage for nanotime triggers an error ("'from' must
be a finite number") when applying exclusions
The [patches/](/patches) subdirectory contains the following patches:
* [drop-outer-gpd.diff][f1]: the simplest change that resolves the
above issues.
* [drop-outer-gpd-no-simplify.diff][f2]: a fix for a currently
unreachable bug in covr's `split_on_line_directives` helper (see
the `drop-outer` case for the pagenum package).
* [proposed-v1][f3]: the actual fix proposed upstream ([r-lib/covr#588][pr])
[f1]: /patches/drop-outer-gpd.diff
[f2]: /patches/drop-outer-gpd-no-simplify.diff
[f3]: /patches/proposed-v1.diff
[pr]: https://github.com/r-lib/covr/pull/588
Slowdown
--------
### data.table
**R 4.3 run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/datatable-r43.stderr#L97
**R 4.4 run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/datatable-r44.stderr#L21
**R 4.4 patched run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/datatable-r44-drop-outer.stderr#L97
### diffobj
**R 4.3 run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/diffobj-r43.stderr#L45
**R 4.4 run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/diffobj-r44.stderr#L21
**R 4.4 patched run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/diffobj-r44-drop-outer.stderr#L45
### R.utils
**R 4.3 run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/rutils-r43.stderr#L161
**R 4.4 run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/rutils-r44.stderr#L161
**R 4.4 patched run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/rutils-r44-drop-outer.stderr#L161
Exclusions error
----------------
### data.table
**R 4.3 run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/datatable-r43.stderr#L15-L16
**R 4.4 run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/datatable-r44.stderr#L15-L20
**R 4.4 patched run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/datatable-r44-drop-outer.stderr#L15-L16
### diffobj
**R 4.3 run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/diffobj-r43.stderr#L15-L16
**R 4.4 run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/diffobj-r44.stderr#L15-L20
**R 4.4 patched run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/diffobj-r44-drop-outer.stderr#L15-L16
### nanotime
**R 4.3 run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/nanotime-r43.stderr#L17-L18
**R 4.4 run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/nanotime-r44.stderr#L17-L22
**R 4.4 patched run**
https://github.com/kyleam/covr-r44-issues/blob/fab8e7bc7fd9705f0671ebf0bf23eecb83780be5/output/nanotime-r44-drop-outer.stderr#L17-L18