Ecosyste.ms: Awesome
An open API service indexing awesome lists of open source software.
https://github.com/leoluk/phab-inlinereview
https://github.com/leoluk/phab-inlinereview
phabricator phabricator-extension
Last synced: 6 days ago
JSON representation
- Host: GitHub
- URL: https://github.com/leoluk/phab-inlinereview
- Owner: leoluk
- License: apache-2.0
- Created: 2021-06-19T14:29:53.000Z (over 3 years ago)
- Default Branch: master
- Last Pushed: 2021-06-19T14:41:35.000Z (over 3 years ago)
- Last Synced: 2024-12-16T23:57:57.992Z (7 days ago)
- Topics: phabricator, phabricator-extension
- Language: Go
- Homepage:
- Size: 130 KB
- Stars: 1
- Watchers: 3
- Forks: 0
- Open Issues: 0
-
Metadata Files:
- Readme: README.md
- License: LICENSE
Awesome Lists containing this project
README
# phab-inlinereview
**Note:** This is no longer maintained, since we no longer use Phabricator. This repository preserves the code in case
anyone else wants to use and maintain it.---
For large or complex changes, it can be a lot easier to do code review from your IDE, with familiar syntax highlighting
and code intelligence features.Use `arc patch D123` to check out a revision.
Soft-reset your repo to HEAD^ using `git reset --soft HEAD^`. The changes you want to review are now staged ("*Changes
to be committed*"). The changes will be highlighted and can easily be reviewed inside the IDE. Any modifications to the
repository you make will be *un*staged ("*Changes not staged for commit*").Once you're done, use the reflog to go back to where you were using `git reset HEAD@{1}`. The unstaged changes you made
on HEAD^ will survive, and you can commit them (in order to create a stacked follow-up revision), and submit
inlinereview comments.The inlinereview tool can submit draft code review comments added as unstaged changes in your local Git working copy.
You need to use the following comment syntax:```lang=diff
+//% This is a code review comment. It can include Remarkup:
+//%
+//% - This is a multi-line list
+//% - Lorem Ipsum
consensusCerts, err := s.consensusService.IssueCertificate(req.Host)
if err != nil {
nil, err
}
```Run the tool once in your working directory, and your comments will visible as unsubmitted drafts in Phabricator. You
can then complete the review in Phabricator and submit it.### IntelliJ highlighting
You can add a custom style for `%\s.+` in Editor → TODO to get highlighting:
![img.png](_images/img.png)
![img_1.png](_images/img_1.png)
You can then add a TODO filter to see a list of all pending comments:
![img_2.png](_images/img_2.png)