https://github.com/nbaztec/repro-keccak-asm-issue
https://github.com/nbaztec/repro-keccak-asm-issue
Last synced: 11 months ago
JSON representation
- Host: GitHub
- URL: https://github.com/nbaztec/repro-keccak-asm-issue
- Owner: nbaztec
- Created: 2024-08-19T15:02:24.000Z (almost 2 years ago)
- Default Branch: main
- Last Pushed: 2024-08-20T11:24:00.000Z (almost 2 years ago)
- Last Synced: 2025-02-04T17:28:20.396Z (over 1 year ago)
- Language: Rust
- Size: 49.8 KB
- Stars: 0
- Watchers: 1
- Forks: 0
- Open Issues: 1
-
Metadata Files:
- Readme: README.md
Awesome Lists containing this project
README
# Summary
When compiling this application with `--features asm-keccak`, the following test fails under Ubuntu and Arch (x86_64), but passes on Mac:
```rust
fn test_foo_fails() {
let a = alloy_primitives::keccak256("testFoo()"); // want: 0x79adbd5094e60c1bc2b963678ff44695d1430b8ccff0b1cd57c03a7f63567822
// got : 0xae33576402a61ff3a4a241b4a91d20ce98b70aa7bf0f388fb857111ec83aef73
let b = alloy_primitives::keccak256("test_Foo()");
println!("testFoo() : {:?}", a);
println!("test_Foo(): {:?}", b);
assert_eq!(format!("{a:?}"), String::from("0x79adbd5094e60c1bc2b963678ff44695d1430b8ccff0b1cd57c03a7f63567822"));
assert_eq!(format!("{b:?}"), String::from("0x45c48c2bd4afc6adc7884fe296b9af10e234ddbc44f2f99f40cfb8b6391e9798")); // this is always correct
}
```
```bash
testFoo() : 0xae33576402a61ff3a4a241b4a91d20ce98b70aa7bf0f388fb857111ec83aef73
test_Foo(): 0x45c48c2bd4afc6adc7884fe296b9af10e234ddbc44f2f99f40cfb8b6391e9798
thread 'tests::test_foo_fails' panicked at src/main.rs:19:9:
assertion `left == right` failed
left: "0xae33576402a61ff3a4a241b4a91d20ce98b70aa7bf0f388fb857111ec83aef73"
right: "0x79adbd5094e60c1bc2b963678ff44695d1430b8ccff0b1cd57c03a7f63567822"
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
failures:
tests::test_foo_fails
test result: FAILED. 0 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s
```
The issue seems to be that the keccak256 hash is incorrectly calculated on linux.
The example has been minimized from a foundry-zksync repository, where these collection of dependencies and their respective imports cause this issue to occur.
If any one of the deps or their imports is removed, then the issue goes away.
```bash
# Running on linux-x86_64 arch
make test # fails
make test-native # passee
```