https://github.com/ryan-williams/pnpm-transdep-issue

Repro: pnpm doesn't correctly install transitive dependencies:
https://github.com/ryan-williams/pnpm-transdep-issue

Last synced: about 2 months ago
JSON representation

Repro: pnpm doesn't correctly install transitive dependencies:

• Host: GitHub
• URL: https://github.com/ryan-williams/pnpm-transdep-issue
• Owner: ryan-williams
• Created: 2024-01-30T03:33:43.000Z (11 months ago)
• Default Branch: main
• Last Pushed: 2024-01-30T14:41:50.000Z (11 months ago)
• Last Synced: 2024-10-20T07:45:40.184Z (3 months ago)
• Language: Dockerfile
• Size: 10.7 KB
• Stars: 0
• Watchers: 1
• Forks: 0
• Open Issues: 0
• Metadata Files:
  • Readme: README.md

Awesome Lists containing this project

README

        
# pnpm-transdep-issue

[pnpm] doesn't install transitive dependencies ([pnpm#7594])

**Note:** this is working as intended; see [this comment on pnpm#7594][pnpm#7594 comment], [this explanation][pnpm flat node_modules] of pnpm's flat node_modules structure, and [this explanation][pnpm strict] of pnpm's "strict" enforcement that packages references directly must be listed explicitly as package.json "dependencies."

---

## Github Actions repro

See [this example run][GHA]:

- `npm` [succeeds][GHA npm]

- `pnpm` [fails][GHA pnpm] with error:

  ```

  deckgl-react.ts(1,20): error TS2307: Cannot find module '@deck.gl/react/typed' or its corresponding type declarations.

  ```

For some reason, `pnpm install deck.gl` fails to install [deck.gl's dependencies][deck.gl dep] (original discussion: [deck.gl#8456])

Also note that `node_modules/@deck.gl` [exists in the npm job][npm ls] but [not in the pnpm job][pnpm ls].

## Docker repro

```bash

build() {

    docker build --build-arg npm=$1 -t pnpm-transdep-issue --progress=plain .

}

build npm   # ✅ works

build pnpm  # ❌ fails

```

See [Dockerfile](Dockerfile):

- deck.gl [depends on][deck.gl dep] @deck.gl/react

- `npm install deck.gl` works as expected (installs `@deck.gl/react`)

- `pnpm install deck.gl` fails to install `@deck.gl/react`

  - As a result, compiling [deckgl-react.ts](deckgl-react.ts) failes:

    ```

    Cannot find module '@deck.gl/react/typed' or its corresponding type declarations.

    ```

The `build` command also runs `ls -l node_modules`, and we see that the `npm` version includes `node_modules/@deck.gl/…` while the `pnpm` version doesn't.

[pnpm]: https://pnpm.js.org/

[deck.gl dep]: https://unpkg.com/browse/[email protected]/package.json

[GHA]: https://github.com/ryan-williams/pnpm-transdep-issue/actions/runs/7706228027

[GHA npm]: https://github.com/ryan-williams/pnpm-transdep-issue/actions/runs/7706228027/job/21001441987

[GHA pnpm]: https://github.com/ryan-williams/pnpm-transdep-issue/actions/runs/7706228027/job/21001442089#step:9:5

[deck.gl#8456]: https://github.com/visgl/deck.gl/issues/8456

[npm ls]: https://github.com/ryan-williams/pnpm-transdep-issue/actions/runs/7706228027/job/21001441987#step:6:7

[pnpm ls]: https://github.com/ryan-williams/pnpm-transdep-issue/actions/runs/7706228027/job/21001442089#step:6:6

[pnpm#7594]: https://github.com/pnpm/pnpm/issues/7594

[pnpm#7594 comment]: https://github.com/pnpm/pnpm/issues/7594#issuecomment-1916495762

[pnpm flat node_modules]: https://pnpm.io/blog/2020/05/27/flat-node-modules-is-not-the-only-way

[pnpm strict]: https://medium.com/pnpm/pnpms-strictness-helps-to-avoid-silly-bugs-9a15fb306308