Ecosyste.ms: Awesome
An open API service indexing awesome lists of open source software.
https://github.com/stevekung/fishnostuck
A small mod that fixes fish stop moving entirely (MC-182763)
https://github.com/stevekung/fishnostuck
Last synced: about 1 month ago
JSON representation
A small mod that fixes fish stop moving entirely (MC-182763)
- Host: GitHub
- URL: https://github.com/stevekung/fishnostuck
- Owner: SteveKunG
- License: mit
- Created: 2023-08-27T13:11:52.000Z (over 1 year ago)
- Default Branch: 1.21
- Last Pushed: 2024-11-05T09:10:53.000Z (about 2 months ago)
- Last Synced: 2024-11-05T10:20:14.858Z (about 2 months ago)
- Language: Java
- Homepage:
- Size: 222 KB
- Stars: 1
- Watchers: 1
- Forks: 1
- Open Issues: 1
-
Metadata Files:
- Readme: README.md
- Changelog: CHANGE_LOG.md
- License: LICENSE.md
Awesome Lists containing this project
README
# FishNoStuck
A small mod that fixes fish stop moving entirely [MC-182763](https://bugs.mojang.com/browse/MC-182763)
Support with Minecraft 1.17.x-1.20.x for Fabric (Quilt maybe?)/Forge
Download on [Modrinth](https://modrinth.com/mod/fish-no-stuck)/[CurseForge](https://legacy.curseforge.com/minecraft/mc-mods/fish-no-stuck)
### How it works
The fish has an AI Goal that scans for the nearest fish, which will randomly select a leader and followers. Then it will let the follower fish follow the leader.
This mod applies bug fix to `FollowFlockLeaderGoal` by checking the nearest fish if it is a leader or not.
If not, it will add into the follower list.
If leader gets added into the follower list.
A Fish Leader will stop and not go to anywhere along with their followers (Forever!).
Unless you hit them or switch gamemode to survival and swim near them.
For Minecraft Bug Report, see: [https://bugs.mojang.com/browse/MC-182763](https://bugs.mojang.com/browse/MC-182763)
### Another fix in this mod is:
- Check entity predicate by using `EntitySelector.NO_CREATIVE_OR_SPECTATOR` instead of `EntitySelector.NO_SPECTATORS` in avoid entity goal.
- Set `checkNoActionTime` to `false` in `FishSwimGoal` to fix fish getting stuck at the current position
- Decreased `schoolSize` from leader fish if the follower fish is getting killed.
### Performance Impact
This mod doesn't improve any game performance, or it has very minor impact, especially for fish.
See [FishNoStuck#1](https://github.com/SteveKunG/FishNoStuck/issues/1)
### Installation
- Install Fabric Loader/MinecraftForge
- Copy mod into `mods` folder
### Backstory
I was working on [Fish of Thieves](https://github.com/SteveKunG/FishOfThieves) by looking at `FollowFlockLeaderGoal` and figure it out how it works, then convert it to use `Brain` system.
By display debug data above an entity.
Then I realize something wrong. A fish with `schoolSize=8` has property `isFollower=true` and has a leader. Which it should not be possible.
So that's the beginning of this mod.
