https://github.com/tedyoung/toward-domain-java8
Exercise for moving away from Anemic Domain.
https://github.com/tedyoung/toward-domain-java8
Last synced: about 1 year ago
JSON representation
Exercise for moving away from Anemic Domain.
- Host: GitHub
- URL: https://github.com/tedyoung/toward-domain-java8
- Owner: tedyoung
- License: gpl-3.0
- Created: 2022-06-28T16:36:39.000Z (almost 4 years ago)
- Default Branch: main
- Last Pushed: 2022-07-05T14:39:33.000Z (almost 4 years ago)
- Last Synced: 2025-03-08T02:04:52.188Z (over 1 year ago)
- Language: Java
- Size: 24.4 KB
- Stars: 1
- Watchers: 2
- Forks: 0
- Open Issues: 0
-
Metadata Files:
- Readme: README.md
- License: LICENSE
Awesome Lists containing this project
README
# Anemic Data Model Exercise
A legacy refactor exercise, focused on the violation of Andy Hunt's [tell don't ask](https://toolshed.com/articles/1998-07-01-TellDontAsk.html) heuristic (also see [Fowler](https://martinfowler.com/bliki/TellDontAsk.html)) principle and suffering from an [anemic domain model](https://martinfowler.com/bliki/AnemicDomainModel.html).
## Instructions
Here you find a simple order flow application.
It's able to create orders, do some calculations (totals and taxes), and manage them (approve/reject and ship).
The old development team did not find the time to build a proper domain model,
but instead preferred to use a procedural style, building this anemic domain model.
Fortunately, they did at least take the time to write unit tests for the code.
Your new CTO, after many bugs caused by this application,
asked you to refactor this code to make it more maintainable and reliable.
## What to focus on
Focus on code smells, such as _Feature Envy_, _Primitive Obsession_, and Data focus instead of Domain focus.
### Remove Setters
You should be able to remove all the setters moving the behavior into the domain objects (_Feature Envy_ perhaps?).
But don't stop there.
If you can remove some test cases because they don't make sense anymore (e.g.: you cannot compile the code to do the wrong thing) feel free to do it!
## Contribute
If you would like to contribute to this exercise adding new cases or smells: please open a pull request!
## Feedback
Feedback is welcome!
How did you find the exercise? Did you learn anything from it?
Please contact me on Twitter [@JitterTed](https://twitter.com/jitterted) or use the GitHub repo wiki!
## History
> This was originally forked from https://github.com/racingDeveloper/tell-dont-ask-kata -- [@racingDeveloper](https://twitter.com/racingDeveloper) on Twitter.
>
> I've updated JUnit to the JUnit 5, and replaced Hamcrest, etc. with AssertJ assertions.
>
> Also replaced references to "kata" to be "exercise"