https://github.com/vmarcella/guessngive
Try and guess a randomly computer generated number or have the computer try and guess one of yours!
https://github.com/vmarcella/guessngive
test text-game
Last synced: 5 months ago
JSON representation
Try and guess a randomly computer generated number or have the computer try and guess one of yours!
- Host: GitHub
- URL: https://github.com/vmarcella/guessngive
- Owner: vmarcella
- License: mit
- Created: 2017-02-25T01:17:28.000Z (almost 9 years ago)
- Default Branch: master
- Last Pushed: 2017-03-06T01:33:02.000Z (almost 9 years ago)
- Last Synced: 2025-04-05T06:22:47.085Z (10 months ago)
- Topics: test, text-game
- Language: C++
- Size: 19.5 KB
- Stars: 1
- Watchers: 2
- Forks: 0
- Open Issues: 0
-
Metadata Files:
- Readme: README.md
- License: License.txt
Awesome Lists containing this project
README
#GuessNGive
##Index
###1. [Details](#Details)
###2. [Demonstrates the use of](#it-demonstrates-mostly-the-use-of)
###3. [Project timeline](#i-started-working-on-this-project)
###4. [Compiler](#this-project-is-compiled-with)
###5. [Desired Improvements](some-things-id-like-to-improve-are)
###6. [Notes](#notes)
##Details
A simple game I made to put what I've learned about C++ so far into use.
##The game has two different game modes you can play:
1. Guessing game
* The computer generates a random number between the numbers 1 and 100 which you have to guess
2. Giving game
* You give the computer a number between 1 and 100 and then the computer tries and guesses it
##It demonstrates mostly the use of...
- Conditional statements
- Logical operators
- iostream file functions
- generating random numbers and seeding the random number generator
##I started working on this project...
February 19, 2017
####and created the repo...
February 24, 2017
##This project is compiled with...
GCC compiler
##Some things I'd like to improve are...
- [x] Implementing an algorithm for the computer to come up with more realistic guesses. The only random number that is actually a "guess" by the computer is the first one generated.
Since the rules of our guessing game state that the secret number has to be within the range of 1-100, we take the remainder of the randomly generated number divided by 100.
This gives us a result of 0-99, which we then add 1 to in order for the result to be within our specified range:
```cpp
int computerGuess = (rand() % 100) + 1;
```
From here on out, the computer generates more guesses by evaluating whether the number it had previously generated is greater than or less than the secret number we had initially gave it.
If the number the computer had previously generated is too high, we're going to subtract a newly generated number from the previous one.
We generate this new number by adding one to the remainder of a randomly generated number divided by the difference of the computers previous guess and the secret number you had entered.
```cpp
computerGuess -= ((rand() % (computerGuess - secretNumber)) + 1);
```
We subtract the computers previous guess from secret number to get the "distance" from the computers number to the number it's trying to guess. Although it does end up guessing the secret number pretty quickly, it's technically cheating since it's calculation is dependent on knowing the secret number.
I'd like to eliminate the dependency on knowing the secret number the user has given and instead calculate the result solely off of the knowledge of it's previous guesses like how another human would do.
Here is how I implemented the evaluation:
```cpp
if(tooHigh)
{
computerGuess -= ((rand() % (computerGuess - secretNumber)) + 1);
tooHigh = false;
}
else
{
computerGuess += ((rand() % (secretNumber - computerGuess)) + 1);
}
```
####Resolved (March 1st, 2017)
The computer now guesses the your secret number using the binary search algorithm. Here is my new implementation:
```cpp
int lowerBoundary = 1;
int upperBoundary = 99;
int computerGuess;
while(!computerCorrect)
{
computerTries++;
if(lowerBoundary > upperBoundary)
{
cout << "Search has terminated as unseccessful, is your set ordered?" << endl;
return 0;
}
computerGuess = (lowerBoundary + upperBoundary) / 2;
if(computerGuess < secretNumber)
{
cout << "The computer has guessed the number " << computerGuess << ", which is too low!" << endl;
lowerBoundary = (computerGuess + 1);
}
else if (computerGuess > secretNumber)
{
cout << "The computer has guessed the number " << computerGuess << ", which is too high!" << endl;
upperBoundary = (computerGuess - 1);
}
else
{
cout << "Congratulations, the computer guessed the number " << computerGuess << " in " << computerTries << " tries." << endl;
computerCorrect = true;
}
}
```
I explain the what's going on within the cpp file. If you'd like more information on how the binary search algorithm works, [here is the Wiki](https://en.wikipedia.org/wiki/Binary_search_algorithm).
- [ ] Testing user input to make sure that the user is giving the required type of data when prompted
For the guessing game:
```cpp
tries++;
cout << "Guess:";
cin >> yourNumber;
if (yourNumber != secretNumber)
{
if (yourNumber > secretNumber)
{
cout << "You guessed " << yourNumber << " which is too high! Please guess again!" << endl;
}
else if (yourNumber < secretNumber)
{
cout << "You guessed " << yourNumber << " which is too low! Please guess again!" << endl;
}
continue;
}
else
{
cout << secretNumber << ", That's correct! You guessed the number in " << tries << "tries!" << endl;
correctGuess = true;
}
```
For the giving game:
```cpp
while(!numEntered)
{
cout << "Welcome to Give the number!" << endl;
cout << "In this game, you have to create a secre number for the computer to guess!" << endl;
cout << "The number has to be inbetween 1 and 100!" << endl;
cout << "Start now!" << endl;
cout << "Enter a secret number:";
cin >> secretNumber;
if (secretNumber > 100 || secretNumber < 0)
{
cout << "Your number is out of bounds! Please try again!" << endl;
}
else if (secretNumber <= 100 && secretNumber >= 1)
{
numEntered = true;
}
}
```
As you can see, giving either game a value other than an integer will cause it to do things that aren't intended and may potentially break it.
- [ ] Modularizing the code.
The functionality of the entire program exists inside the main function. I think that's kind of enough said.
- [x] Commenting on code.
Is there a better system I could adopt in order to create cleaner comments?
###Resolved (March 5th, 2017)
In my opinion, the best commenting system you can ever implement is one where the code "comments itself". If the code is clean and class/variable/function/etc names are all descriptive, the code will explain itself.
##Notes
####February 26th, 2017
This is simply just a project to help me Develop my skills in C++. I am fairly new to the language and have just started teaching myself again. Any Feedback/critism on what I am doing right/wrong would be greatly appreciated.
####March 1st, 2017
The giving games bot now guesses your number using the [binary search algorithm](https://en.wikipedia.org/wiki/Binary_search_algorithm). I also specified which items I'll be using from the std rather than including the entire namespace. Plan to modularize the code tomorrow and look into securing the program from taking in user input that isn't of the required type.